Fixed sounds table #168
Open
Fixed sounds table #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alt.wav and dist.wav were not present in the psv files, listing all sounds. takeoff.wav-"takeoff flight mode" was overwritten by takeoff.wav-"auto takeoff mode" in the english_px4.psv. Since the PX4 version is older, I changed the other filename to takeoffm.wav.
|
mhmm, you're mixing ardupilot and px4 sounds, soundfiles have to have the exact same name of the corresponding flightmode, you cannot rename them at will |
|
Well, at least when I made this PR, there was a bug where "takeoff flight mode" was missing, because it got overwritten by PX4. Not sure if that got fixed. But it seems to me, one of the files should be renamed to resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alt.wavanddist.wavwere not present in the PSV files, where the sounds are listed.takeoff.wav-"takeoff flight mode" was overwritten bytakeoff.wav-"auto takeoff mode" from theenglish_px4.psv. Since the PX4 version is older, I changed the other filename totakeoffm.wav.